Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossplatform font loading #2530

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Crossplatform font loading #2530

wants to merge 11 commits into from

Conversation

Jklawreszuk
Copy link
Collaborator

@Jklawreszuk Jklawreszuk commented Nov 24, 2024 •
edited
Loading

PR Details

This PR moves font import from DirectWrite to FreeType. Also, It replaces System.Drawing.Bitmap with the FreeImageBitmap class + small refactor.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk marked this pull request as draft November 24, 2024 00:40
@Jklawreszuk Jklawreszuk force-pushed the xplat-font-loading branch 5 times, most recently from 4bc2a75 to 940a72e Compare December 22, 2024 07:28
@Jklawreszuk Jklawreszuk force-pushed the xplat-font-loading branch 2 times, most recently from fb95b6d to 5b276cf Compare December 28, 2024 15:17
@Jklawreszuk Jklawreszuk force-pushed the xplat-font-loading branch 2 times, most recently from b3687ee to 5cc650a Compare January 9, 2025 01:38
@Jklawreszuk
Copy link
Collaborator Author

It took soo long but my changes are ready for review :)

@Jklawreszuk Jklawreszuk marked this pull request as ready for review January 17, 2025 23:34
@Jklawreszuk
Copy link
Collaborator Author

Jklawreszuk commented Jan 17, 2025 •
edited
Loading

Quick note here: Though this may not be noticable, but our old FreeType (2.6?) wrapper does not provide support for ClearType (it uses Harmony (?) instead), so perhabs I should create issue for this. Otherwise It almost one to one implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jklawreszuk